Skip to content
This repository was archived by the owner on Jan 14, 2024. It is now read-only.

Conversation

@AdrianIlovan
Copy link

Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in HOW_TO_MARK.md in the root of this repository

Your Details

  • Your Name: Adrian Ilovan
  • Your City: London
  • Your Slack Name: AdrianIlovan

Homework Details

  • Module: Javascript 1
  • Week: 2

Notes

  • What did you find easy?
    Booleans, if statement
  • What did you find hard?
    counting , adding i++
  • What do you still not understand?
    this function :

function printOddNumbers(limit) {
let i = 1;
while (i <= limit) {
if (i % 2 !== 0) {
console.log(i);
}
i++;
}
}

  • Any other notes?

@AdrianIlovan AdrianIlovan requested a review from kwebster77 April 12, 2023 18:38

if (isHappy) {
function getMood(isHappy) {
if (isHappy === true) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice using strict equality

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :)

let isBigEnough;

if (isBigEnough) {
if (num > 10) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

function isAcceptableUser(userAge, isLoggedIn) {}

function isAcceptableUser(userAge, isLoggedIn) {
if (userAge >= 18 && isLoggedIn === true) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect :)

*/
function buyTwoGetTheCheapestFree(price1, price2) {}
function buyTwoGetTheCheapestFree(price1, price2) {
let cheaperPrice = price1 < price2 ? price1 : price2;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good use of the ternary operator

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to be honest, ChatGPT helped.


function countReverse(number) {}
function countReverse(number) {
for (let i = number; i >= 1; i--) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good for loop

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ta :)

@kwebster77
Copy link

Hi Adrian-- Nice job on this! Looks like you really understand the fundamentals well. Keep up the good work!

@kwebster77 kwebster77 added the reviewed A mentor has reviewed this code label Apr 16, 2023
@AdrianIlovan AdrianIlovan changed the title London10/adrianilovan LND10 | Adrian Ilovan | JS1 Coursework Week2 Jun 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

reviewed A mentor has reviewed this code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants